Implement Resolver.asMemberOf for Properties and Functions #110
Conversation
api/src/main/kotlin/com/google/devtools/ksp/processing/Resolver.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/com/google/devtools/ksp/symbol/KSFunctionType.kt
Outdated
Show resolved
Hide resolved
|
this is ready for review (besides I need to rebase w/ master). Renamed KSFunctionType to KSFunction. |
This is just a copy of the implementation in Room. Still need more tests, support for other declarations and possible optimizations
Old type substitutor seems to have problems with * projection where as new one seems to work (failing test case: receiveArgs method). I've replaced the code to use the new substitutor (even with fields) and also implemented a fallback implementation for KSFunctionType that derives from a KSFunctionDeclaration.
|
rebased, ready for review. |
compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSFunctionImpl.kt
Show resolved
Hide resolved
compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt
Show resolved
Hide resolved
| } | ||
| val typeSubstitutor = containing.kotlinType.createTypeSubstitutor() | ||
| val substituted = declaration.substitute(typeSubstitutor) | ||
| return KSFunctionImpl(substituted) |
There was a problem hiding this comment.
Can you cache the creation of KSFunctionImpl like this?
There was a problem hiding this comment.
i'm not sure if this is worth caching, the value is quite specific to an owner + declaration.
But even if I wanted to cache that, substitute returns CallableDescriptor which does not seem to enforse implementing proper equals.
I've actually tried to run substitution twice between a List<String> type and List#get and they both returned different descriptors.
I can try to cache in the resolverImpl's asMemberOf with a composite key of KSFunctionDeclaration,KSType though again, i'm not sure how useful that cache would be.
There was a problem hiding this comment.
with a composite key of
KSFunctionDeclaration,KSType
Sounds good to me. Besides performance[1], like what you said, it comes with proper equals.
[1] asMemberOf is inherently expensive. I'm a little bit surprised that the substituter returned different instances when called twice, which means that some of the computations are redundant.
There was a problem hiding this comment.
i implemented caching, though i don't have KSFUnction#equals, I guess probably should implement it as well?
Also, might be better to do it as a followup to get this CL in.
compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt
Show resolved
Hide resolved
This PR implements functionality to see a property/function as member of a given type.
Internally, it uses the Substitutor from the compiler.
Since function declarations contain multiple types, I've added a new
KSFunctionTypewhich can hold this information.It supports properties and functions declared in a class but does not support extension functions yet. We need a new API for them since they are not really a member of the receiver type.
When a substitution fails, we return the type or KSFunctionType inferred from the declaration of the property/function respectively.
Fixes: #49