This repository was archived by the owner on Jan 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 282
Feature/androidx #100
Open
techjin
wants to merge
115
commits into
google:master
Choose a base branch
from
Buzzvil:feature/androidx
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/androidx #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TabMessageView 생성, Screen 에 붙이기 * onDockChange 에서 MessageView 방향 전환 * Animation detail * MIN, MAX vertical position 을 정해서 tab 이 화면 밖을 벗어나지 못하게 함 * Design Review - Preview 상태에서 다음 State 로 변할 때 상황에 따라 Animation 보여주지 않기 * add 'Preview' in StateChangeListener
[BZZRWRDD-254] Collapsed State일때 5초가 지나면 hover view가 반투명해지도록 변경
* View 를 넘기는 방식 대신 Rect 넘기기, FloatingTab 과 MessageView 는 어떤 뷰에 같이 속해 있지 않음
…efactor callbacks (#8) * HoverViewState control 방법 변경 - hover view 에서 state 변경을 관리하고, 각 state는 본인의 로직만 구현
…ler 로 분리하고 Window, View 공통 요소 분리 (#9)
* Anchored 일때 shrink, 나올 때 expand * selected 조정해서 아이콘 변경시키기
…n TabMessageView (#12)
…러개의 View를 받아와서 터치 영역을 생성 할 수 있도록 수정 (#13) * Container View 크기가 바뀔 때 (뷰 영역 or Screen Orientation 변화) FloatingTab, TouchController 의 위치 계산이 잘못되는 버그 수정
* preview를 보여줄 때 floatingTab을 drag할때 preview가 drag되는 이슈 수정 * OnPositionChangedListener를 다시 FloatingTab으로 옮기고, onLayoutChanged 이벤트에 대한 touchView의 이동은 개별 view에서 관리하도록 수정
* Floating 버튼이 아래쪽으로 내려가 보이지 않는 이슈 수정 * Drag 후 바로 tap을 할 경우 hover view가 null일때가 있어 NPE가 발생하는 이슈 해결 * Dragger가 deactivate 된 상태에서도 callback을 계속 전달해 NPE 발생하는 이슈 수정
* exit view 변경 * Alpha 0.4 로 변경
* Hidden State으로 전환될 때 hover view에 셋팅된 position 값이 있을 경우 그 position으로 이동 후 숨김처리할 수 있도록 변경 * Hidden State로 전환 중 빠르게 다른 State으로 넘어갈 경우 NPE가 발생하는 이슈 수정 * log 제거
* Collapsed state일 때 일정 시간이 지나면 반투명해지거나 아이콘이 사라질 수 있도록 설정할 수 있게 변경 * Alpha 값을 상수로 변경
getWidth()가 0인 경우에는 아직 올바른 위치가 아니므로 실행하지 않고 이전과 다른 position, side (왼쪽, 오른쪽)이면 새로 그린다.
[CD-51] Close pop with gesture, add animation
This reverts commit 4f49a5a
[CD-91] Fix disappearing pop icon
[CD-82] Fix pop throw close
add public to hover view state
fix lint whitespace before
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.