Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove best effort support for ubuntu 18.04 #1537

Merged
merged 3 commits into from
Feb 6, 2023
Merged

remove best effort support for ubuntu 18.04 #1537

merged 3 commits into from
Feb 6, 2023

Conversation

dmah42
Copy link
Member

@dmah42 dmah42 commented Feb 6, 2023

as of 2022-01-12, github removed support for ubuntu-18.04. as such, we are removing it from github actions and no longer will support it actively.

it was already "best effort" but time marches on.

@dmah42 dmah42 requested a review from LebedevRI February 6, 2023 14:08
@LebedevRI
Copy link
Collaborator

While i don't have an opinion on what we should do regarding supporting that particular distro,
i feel like i should point out that it is not relevant what linux distributions are natively supported
by github runners, because there's such thing as a docker, with idea being:
use the freshest distro in runs-on: field, and then just pick the distro you want
(from whatever the source, e.g. https://hub.docker.com/_/ubuntu), and specify it in container: image:
That is what i have always been doing, at least.

See https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container

@dmah42
Copy link
Member Author

dmah42 commented Feb 6, 2023

While i don't have an opinion on what we should do regarding supporting that particular distro, i feel like i should point out that it is not relevant what linux distributions are natively supported by github runners, because there's such thing as a docker, with idea being: use the freshest distro in runs-on: field, and then just pick the distro you want (from whatever the source, e.g. https://hub.docker.com/_/ubuntu), and specify it in container: image: That is what i have always been doing, at least.

See https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container

yeah, we could. i'm ok with dropping support for this particular platform though.

@dmah42
Copy link
Member Author

dmah42 commented Feb 6, 2023

maybe we can use containers for the sanitizer builds... or at least a shared cache so we don't keep rebuilding the world for each one.

@dmah42
Copy link
Member Author

dmah42 commented Feb 6, 2023

sanitizer builds are timing out.. that's next on my list.

@dmah42 dmah42 merged commit 94083ca into main Feb 6, 2023
@dmah42 dmah42 deleted the no18-04 branch October 23, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants