Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Solaris compilation (#1499) #1500

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix Solaris compilation (#1499) #1500

merged 1 commit into from
Oct 6, 2022
+17 −11

Conversation

rorth
Copy link
Contributor

@rorth rorth commented Oct 5, 2022

This patch fixes compilation on Solaris, addressing the problems reported in Issue #1499:

  • Provide HOST_NAME_MAX definition.
  • Match sysconf(3C) return type.
  • Avoid -Wcast-qual warnings with libkstat(3KSTAT) functions.
  • Avoid clash with <floatingpoint.h> single typedef.

@rorth
Fix Solaris compilation (google#1499)
371cf9e 
This patch fixes compilation on Solaris, addressing the problems reported
in Issue google#1499:

* Provide `HOST_NAME_MAX` definition.
* Match `sysconf(3C)` return type.
* Avoid `-Wcast-qual` warnings with `libkstat(3KSTAT)` functions.
* Avoid clash with `<floatingpoint.h>` `single` typedef.
@dmah42 dmah42 merged commit 12e0d70 into google:main Oct 6, 2022
@dmah42
Copy link
Member

dmah42 commented Oct 6, 2022

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmah42 dmah42 dmah42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rorth @dmah42 @kunichik