Do not depend on unversioned python binary

[MatzeB]

Some linux distributions no longer provide python binary and require usage of python3 instead. This changes the scripts here and uses cmake find_package(Python3 when running python.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[LebedevRI]

Is the CMake change nessesary given the rest of the diff?
Put differently, would dropping it still solve your issue?

Originally posted by @LebedevRI in #1495 (comment)

[MatzeB]

Is the CMake change nessesary given the rest of the diff? Put differently, would dropping it still solve your issue?

Well either the cmake changes or the shebang #! changes fixes things for me on CentOS8. I thought going through find_package(Python3 was just good cmake style, but happy to drop it from the change.

[LebedevRI]

I think it's not right to have the shebang AND do that CMake dance.
I would guess the shebang thing should be enough,
but then we indeed probably want to check that python interpreter is present at CMake time.
But then if we run those scripts via interpreter, does the shebang help with anything?

Anyways let's just merge as is i guess.

[LebedevRI]

(please resolve the CLA issue, though.)

[MatzeB]

Well, the shebang still helps people running the scripts manually.

Still looking through my companies policies about signing the CLA...

[LebedevRI]

CLA still seems stuck, should have it unstuck?

[dmah42]

i checked manually and @MatzeB hasn't signed the Google CLA as far as i can tell.

[MatzeB]

I am told CLA should work now. And when I go to https://cla.developers.google.com/clas I see "You are covered by the following corporate agreements:" "

Google Corporate CLA | Facebook, Inc. | Apr 29, 2016 12:42 PDT

Google Corporate CLA Facebook, Inc. Apr 29, 2016 12:42 PDT

Not sure why it's not working, does it still require the old [email protected] mails instead of [email protected]?

[LebedevRI]

Let's see if reopening PR helps.

[dmah42]

i just forced a rescan on my end

[joshmcorreia]

This merge forced my CI/CD pipelines that use googlebenchmark to fail because our images don't have Python installed, even though googlebenchmark has never required Python before.

[LebedevRI]

This merge forced my CI/CD pipelines that use googlebenchmark to fail because our images don't have Python installed, even though googlebenchmark has never required Python before.

Looks like you need to specify -DBENCHMARK_ENABLE_TESTING=OFF.

[joshmcorreia]

Looks like you need to specify -DBENCHMARK_ENABLE_TESTING=OFF.

We want it on, and have had no issues with it in the past...

[LebedevRI]

Then i guess perhaps this change should be changed to use find_program() instead of requiring python3-dev package to be present, that would profile cmake files.

[joshmcorreia]

That would be great, this is currently blocking all of my company's pipelines so we can't release anything. If you could revert this change while coming up with an update it would be greatly appreciated.

[LebedevRI]

That would be great, this is currently blocking all of my company's pipelines so we can't release anything. If you could revert this change while coming up with an update it would be greatly appreciated.

I would love to, but apparently i can not.

[joshmcorreia]

Thanks for the revert!