Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss sources of variance in the user guide #1481

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Discuss sources of variance in the user guide #1481

merged 4 commits into from
Sep 9, 2022

Conversation

matta
Copy link
Contributor

@matta matta commented Sep 3, 2022

It took me a long time to figure some of this stuff out, so it would be great to include it in the guide, assuming it is correct enough!

@dmah42
Copy link
Member

dmah42 commented Sep 5, 2022

could you pull this out of the user guide into its own document? i think it's important enough to get that but also isn't something someone who just wants to know how to use/run the thing needs to know right away.

Add reducing_variance.md as a place to discuss things related to variance
and, in the future, statistical interpretation of benchmark results.
@matta
Copy link
Contributor Author

matta commented Sep 8, 2022

could you pull this out of the user guide into its own document? i think it's important enough to get that but also isn't something someone who just wants to know how to use/run the thing needs to know right away.

Done. I also moved the performance governor discussion to the new document, but a small forwarding paragraph in the user guide in case people have links there, or find the specific error message issued by the benchmark code there.

@matta matta closed this Sep 8, 2022
@matta
Copy link
Contributor Author

matta commented Sep 8, 2022

Oopse, reopening. I'm not very familiar with github and didn't realize what "close with comment" did. ;-)

@matta matta reopened this Sep 8, 2022
@dmah42
Copy link
Member

dmah42 commented Sep 9, 2022

this is great. i think we'll also move the "random interleaving" into this reducing variance doc too as it is meant precisely for that.

let me know if you want to do that too or if not i'll just merge this.

@matta
Copy link
Contributor Author

matta commented Sep 9, 2022

let me know if you want to do that too or if not i'll just merge this.

My preference is to merge it now and then make further changes.

@dmah42 dmah42 merged commit 1c26d8a into google:main Sep 9, 2022
@dmah42
Copy link
Member

dmah42 commented Sep 9, 2022

thank you!

@matta matta deleted the docs-variance branch September 9, 2022 16:55
dmah42 pushed a commit that referenced this pull request Sep 14, 2022
* Discuss sources of variance in the user guide

* Mention cpufreq/boost

* Pull variance material into a new document

Add reducing_variance.md as a place to discuss things related to variance
and, in the future, statistical interpretation of benchmark results.

Co-authored-by: Dominic Hamon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants