-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build issues on window #1449
Conversation
oontvoo
commented
Jul 27, 2022
- Added missing dlimport/export attributes in function definitions. (They are needed in both decls and defs)
- Removed dlimport/dlexprt attribute in private field. (global_context is not exported anywhere).
- Added missing dlimport/export attributes in function definitions. (They are needed in both decls and defs) - Removed dlimport/dlexprt attribute in private field. (global_context is not exported anywhere).
@dominichamon : more fixes :) |
":(.text+0x2e7e): undefined reference to 'benchmark::internal::global_context[abi:cxx11]'" suggests we do need something on |
Oh, turns out - there are a few places in the code where this variable was forward-declared then used :( |
In general, benchmark exports too many |
that's really clean. i'm going to merge this to resolve the current issues but a longer term plan to move things to internal library sounds great. |