Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWARF5 attribute forms DW_FORM_line_strp #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rtoax
Copy link
Contributor

@Rtoax Rtoax commented Mar 17, 2023

This submit try to fix [0]

gcc commit 3aa46b47b266("dwarf2out.c (debug_line_str_section): New variable.") introduct DW_FORM_line_strp = 31(0x1f).

Error:

  $ perf record -b -e br_inst_retired.near_taken:pp -- ./redis-server
  $ create_gcov --binary=./redis-server --profile=perf.data --gcov=redis-server.gcov -gcov_version=1
  [WARNING:/home/rongtao/Git/google/autofdo/third_party/perf_data_converter/src/quipper/perf_reader.cc:1320] Skipping 120 bytes of metadata: HEADER_CPU_TOPOLOGY
  [WARNING:/home/rongtao/Git/google/autofdo/third_party/perf_data_converter/src/quipper/perf_reader.cc:1067] Skipping unsupported event PERF_RECORD_ID_INDEX
  [WARNING:/home/rongtao/Git/google/autofdo/third_party/perf_data_converter/src/quipper/perf_reader.cc:1067] Skipping unsupported event PERF_RECORD_CPU_MAP
  [WARNING:/home/rongtao/Git/google/autofdo/third_party/perf_data_converter/src/quipper/perf_reader.cc:1067] Skipping unsupported event UNKNOWN_EVENT_82
  [INFO:/home/rongtao/Git/google/autofdo/third_party/perf_data_converter/src/quipper/perf_reader.cc:1058] Number of events stored: 26469
  [INFO:/home/rongtao/Git/google/autofdo/third_party/perf_data_converter/src/quipper/perf_parser.cc:274] Parser processed: 13 MMAP/MMAP2 events, 7 COMM events, 5 FORK events, 0 EXIT events, 26364 SAMPLE events, 25839 of these were mapped, 0 SAMPLE events with a data address, 0 of these were mapped
  WARNING: Logging before InitGoogleLogging() is written to STDERR
  W20230317 14:17:19.056632 32875 legacy_addr2line.cc:41] File './redis-server' has no .debug_addr section.
  W20230317 14:17:19.056703 32875 legacy_addr2line.cc:41] File './redis-server' has no .debug_ranges section.
  F20230317 14:17:19.056878 32875 dwarf2reader.cc:836] Unhandled form type
  *** Check failure stack trace: ***
  Aborted (core dumped)

@google-cla
Copy link

google-cla bot commented Mar 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Rtoax Rtoax force-pushed the p001-DW_FORM_line_strp branch 2 times, most recently from c0f54af to 96a4d20 Compare May 12, 2023 07:23
@Rtoax
Copy link
Contributor Author

Rtoax commented May 12, 2023

@denik82 Please review this PR, thanks!

This submit try to fix issue google#159 [0]

gcc[1] commit 3aa46b47b266("dwarf2out.c (debug_line_str_section): New
variable.") introduct DW_FORM_line_strp = 31(0x1f).

  Error message:

  $ perf record -b -e br_inst_retired.near_taken:pp -- ./redis-server
  $ create_gcov --binary=./redis-server --profile=perf.data \
	--gcov=redis-server.gcov -gcov_version=1
  ...
  F20230317 14:17:19.056878 32875 dwarf2reader.cc:836] Unhandled form type
  *** Check failure stack trace: ***
  Aborted (core dumped)

[0] google#159
[1] git://gcc.gnu.org/git/gcc.git

Signed-off-by: Rong Tao <[email protected]>
@Rtoax Rtoax force-pushed the p001-DW_FORM_line_strp branch from 96a4d20 to 7b243f9 Compare May 12, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dwarf2reader.cc:835: Unhandled form type
1 participant