This repository was archived by the owner on Aug 6, 2024. It is now read-only.
Easy run script and stamped binaries #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jmichelp
reviewed
Oct 16, 2020
.bazelrc
Outdated
| @@ -1 +1 @@ | |||
| build --cxxopt='-std=c++17' | |||
| build --cxxopt='-std=c++17' --stamp --workspace_status_command=tools/workspace_status.sh | |||
There was a problem hiding this comment.
Good point. I see 3 solutions:
- adapt this solution
- use Python, with the disadvantage of another requirement
- use the toolchain config and require the user to set the correct platform
WDYT?
There was a problem hiding this comment.
I implemented (1), but since I don't have a Windows for testing here, it's basically a shot in the dark. I opened #36 to track that.
jmichelp
reviewed
Oct 19, 2020
jmichelp
approved these changes
Oct 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #14, a discussion started about the JSON format. To not block the other code changes from that PR, #14 will be closed and useful features are added it.
This PR has all code changes from #14, without including the results. All other result format changes are dummies for after finalizing the discussion on the intended format. For an easy review, changed are left as reviewed before, except for the removal of initial results.