Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ldap #20724

Merged
merged 1 commit into from
Jul 11, 2024
Merged

update ldap #20724

merged 1 commit into from
Jul 11, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jul 10, 2024

update openldap image and tls settings

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

update openldap image and tls settings

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 requested a review from a team as a code owner July 10, 2024 11:04
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (c8c11b4) to head (98733c6).
Report is 239 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20724       +/-   ##
===========================================
+ Coverage   45.36%   66.24%   +20.87%     
===========================================
  Files         244     1045      +801     
  Lines       13333   113501   +100168     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75188    +69139     
- Misses       6983    34201    +27218     
- Partials      301     4112     +3811     
Flag Coverage Δ
unittests 66.24% <ø> (+20.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

@wy65701436 wy65701436 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Jul 11, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 0da13eb into goharbor:main Jul 11, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants