-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around Face3::get_area() bug in engine #4
Comments
For a case someone stumbles upon buoyancy-related issues: Pull request mentioned has been merged to godot's master and 3.x-branches. So if someone is using those they may want to remove the workaround. |
Thanks. Since this fix will appear in 3.4, I can add some automatic version detection to apply/remove the workaround at compile time. |
… now that the engine bug has been fixed for 3.4.
Unless a user has manually fixed the bug in the engine source, the version detection added in d5c34d6 should just do the right thing without any user intervention. |
We rely on the Face3::get_area() function returning the correct result, but it returns a value twice the actual area.
Until the pull request with the fix is merged, we could divide the result of the function in half ourselves. This should also be noted in the documentation in case someone fixes the function on their own.
godotengine/godot#37048
godotengine/godot#37064
The text was updated successfully, but these errors were encountered: