-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(p/demo/uassert): amend ineffective assignment #2936
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2936 +/- ##
==========================================
- Coverage 60.95% 60.95% -0.01%
==========================================
Files 564 564
Lines 75273 75273
==========================================
- Hits 45884 45883 -1
- Misses 26019 26021 +2
+ Partials 3370 3369 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It looks fine. It seems you've made modifications because it was always outputting as an |
I was looking to understand uassert package and saw this warning from gnopls: I think the function would work correctly but there's still an error on that line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description