[A8][Amarelo Designs] Fix the Insecure Deserialization vulnerability changing Pickle to JWT #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey, @secampos! Your implementation of JWT instead of Pickle-based tokens looks very good! 🐼 🚀
I just left a suggestion regarding a hardcoded admin password in the source code
| "username":username, | ||
| "admin":True, | ||
| "sessionId":token, | ||
| "exp": datetime.datetime.utcnow() + datetime.timedelta(seconds=600) |
| @@ -19,11 +22,20 @@ def login(): | |||
|
|
|||
| if username == "admin" and password == "admin": | |||
There was a problem hiding this comment.
What do you think about chaning this default password here? Using an environment variable as you did with JWT_SECRET_KEY would be great
There was a problem hiding this comment.
Thanks, @gustavocovas. Now the application is getting the user's credentials from the environment variables.
gustavocovas
approved these changes
May 28, 2020
gustavocovas
added
the
mitigation solution 🔒
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution refers to which of the apps?
A8 - Amarelo Designs
What did you do to mitigate the vulnerability?
The vulnerability was fixed changing the Pickle to JWT.