adjust string for handling rate limit error #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR adjusts the error matching string used for detecting API rate limit exceeded errors.
- Updated error message string in wrapApiConfigurationError to remove a site-specific reference
- Aims to treat appropriate API errors as configuration errors
Reviewed Changes
| File | Description |
|---|---|
| src/api-client.ts | Modified error string to handle rate limit errors |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/api-client.ts:252
- Verify that the new error message string sufficiently covers all expected rate limit error responses. If some responses include additional context such as a site identifier, you may need to adjust the pattern to capture those cases.
e.message.includes("API rate limit exceeded for installation") ||
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
nickfyson
force-pushed
the
nickfyson/adjust-rate-error-string
branch
from
ba1abe7 to
7b7ed63
Compare
NlightNFotis
approved these changes
Mar 6, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the string used to match rate limit error responses and ensure they're treated as configuration errors.
Merge / deployment checklist