Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public header includes private header #244

Closed
karen-arutyunov opened this issue Oct 27, 2021 · 1 comment · Fixed by #248
Closed

Public header includes private header #244

karen-arutyunov opened this issue Oct 27, 2021 · 1 comment · Fixed by #248

Comments

@karen-arutyunov
Copy link

While packaging cmark-gfm 0.29.0.gfm.2 libraries for build2 toolchain, I have noticed that the public header cmark-gfm-core-extensions.h includes the private header config.h:

#include "config.h" // for bool

Thus building a program that includes cmark-gfm-core-extensions.h against the installed cmark-gfm libraries fails with:

/tmp/install/include/cmark-gfm-core-extensions.h:10:10: fatal error: config.h: No such file or directory
@boris-kolpackov
Copy link

From the README:

The library and program are written in standard C99 [...]

Since <stdbool.h> is available from C99, I wonder if the configure check is even necessary?

ryantm added a commit to ryantm/cmark-gfm that referenced this issue Nov 25, 2021
@ryantm
cmark-gfm-core-extensions: use stdbool.h instead of private header
4517fef 
fixes github#244
@ryantm ryantm mentioned this issue Nov 25, 2021
Merged
synkathairo added a commit to synkathairo/ghostwriter that referenced this issue Dec 7, 2022
@synkathairo
Update cmark config.h to stdbool.h
c3b2dc1 
a private header is utilized
See pertinent remark: github/cmark-gfm#244
@redstrate redstrate mentioned this issue Jan 11, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmark-gfm-core-extensions: use stdbool.h instead of private header ryantm/cmark-gfm
2 participants
@karen-arutyunov @boris-kolpackov