Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aci): issue alert action migration util for pagerduty/opsgenie #82794

Conversation

iamrajjoshi
Copy link
Member

continuing #82742: adding support for pagerduty/opsgenie

@iamrajjoshi iamrajjoshi requested review from cathteng and a team December 31, 2024 21:36
@iamrajjoshi iamrajjoshi self-assigned this Dec 31, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 92.80576% with 10 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ry/workflow_engine/migration_helpers/alert_rule.py 90.00% 5 Missing ⚠️
...y/workflow_engine/migration_helpers/rule_action.py 88.88% 5 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                               @@
##           raj/issue-alert-migration-helper-messaging   #82794      +/-   ##
==============================================================================
+ Coverage                                       79.40%   80.43%   +1.03%     
==============================================================================
  Files                                            7313     7315       +2     
  Lines                                          322544   322681     +137     
  Branches                                        21039    21039              
==============================================================================
+ Hits                                           256102   259546    +3444     
+ Misses                                          66038    62731    -3307     
  Partials                                          404      404              

@iamrajjoshi iamrajjoshi marked this pull request as draft January 8, 2025 23:01
@iamrajjoshi iamrajjoshi force-pushed the raj/issue-alert-migration-helper-messaging branch from 88170ee to 8aad757 Compare January 14, 2025 22:01
@iamrajjoshi
Copy link
Member Author

closed in favor of #83565

@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants