-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sveltekit): Add bundle size optimizations to plugin options #13318
Conversation
hmm, now that I look at this - maybe it would make more sense to add the We can still merge this as-is and then remove the alias once we published this upstream & bumped this in here, though! |
This was already done in this PR and and I just saw it is also released: https://github.com/getsentry/sentry-javascript-bundler-plugins/releases/tag/2.22.0 I will update the version :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the option merging logic!
Makes it possible to add bundle size optimizations along with source maps options to the SvelteKit plugin options like this:
A bit of refactoring was done as well in the PR:
./types
generateVitePluginOptions
which merges all SvelteKit plugin options correctly to create the Vite Plugin options (+ tests for this function)part of #13011