feat(solidstart): Filter out low quality transactions for build assets #13222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
added
the
Package: solidstart
s1gr1d
approved these changes
Aug 5, 2024
| return event; | ||
| } | ||
| // Filter out transactions for build assets | ||
| if (event.transaction?.match(/^GET \/_build\//)) { |
There was a problem hiding this comment.
Not for this PR but something to keep in mind in general: is it possible in solidstart to change the name of the build directory?
There was a problem hiding this comment.
It's generally possible to change, but vinxi has problems at build time when the build folder isn't named _build. I think for now this won't change but we can revisit this if it ever does.
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
