fix(utils): Handle when requests get aborted in fetch instrumentation #13202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
changed the title
3 tasks
size-limit report 📦
|
AbhiPrasad
force-pushed
the
abhi-fetch-abort-controller
branch
3 times, most recently
from
f260a36 to
f9e328c
Compare
AbhiPrasad
force-pushed
the
abhi-fetch-abort-controller
branch
from
f9e328c to
7da58d1
Compare
|
okay I think the e2e test covers it, but we probably also want some tests in https://github.com/getsentry/sentry-javascript/tree/develop/dev-packages/browser-integration-tests to validate in firefox and safari as well. |
lforst
reviewed
Aug 5, 2024
...s/browser-integration-tests/suites/integrations/httpclient/fetch/withAbortController/test.ts
Outdated
Show resolved
Hide resolved
lforst
approved these changes
Aug 5, 2024
lforst
reviewed
Aug 5, 2024
...s/browser-integration-tests/suites/integrations/httpclient/fetch/withAbortController/test.ts
Outdated
Show resolved
Hide resolved
amoskl
reviewed
Aug 25, 2024
| // NOTE: If you are a Sentry user, and you are seeing this stack frame, | ||
| // it means the sentry.javascript SDK caught an error invoking your application code. | ||
| // This is expected behavior and NOT indicative of a bug with sentry.javascript. | ||
| throw error; |
There was a problem hiding this comment.
@lforst this is a breaking change for apps that do not handle fetch exceptions :( as they did not get the exceptions before and now they do....
There was a problem hiding this comment.
Can you elaborate? Ideally in a new issue. I do not think this alters behaviour. This actually fixes a bug where we swallowed errors.
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #13187
WIP as we get better test cases