feat(nuxt): Filter out Nuxt build assets #13148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
requested review from
a team,
stephanie-anderson,
AbhiPrasad,
lforst and
Lms24
and removed request for
a team and
stephanie-anderson
s1gr1d
commented
Aug 1, 2024
Comment on lines
44
to
45
| // todo: url not yet parametrized | ||
| expect(transactionEvent.transaction).toBe('GET /test-param/1234'); |
There was a problem hiding this comment.
I am not sure why this is the case here - it shows /test-param/* in the UI but 1234 here. Relay seems to pick that up, but shouldn't the SDK as well?
There was a problem hiding this comment.
Isn't that because we aren't hitting relay, but our tunnel?
lforst
approved these changes
Aug 1, 2024
| if (event.type === 'transaction') { | ||
| // Filter out transactions for Nuxt build assets | ||
| // This regex matches the default path to the nuxt-generated build assets (`_nuxt`). | ||
| if (event.transaction?.match(/^GET \/_nuxt\//)) { |
There was a problem hiding this comment.
l: Maybe let's add a small TODO comment here to dynamically match this path based on the nuxt build output folder so that we don't forget.
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering out events of the
_nuxtbuildAssetDir. Next step would be to change the regex based on the folder name (as this could be changed in the nuxt config during build time - but probably doesn't happen too often).Also added some unit tests for the server-side of the SDK.
Before:
After:
