-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable CaptureFailedRequests by default #2507
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bd284cf | 1241.12 ms | 1249.22 ms | 8.10 ms |
f8045b6 | 1206.76 ms | 1233.41 ms | 26.65 ms |
ae5ecd1 | 1226.73 ms | 1250.96 ms | 24.23 ms |
459ae5e | 1223.84 ms | 1250.14 ms | 26.31 ms |
ba46ce3 | 1231.70 ms | 1250.86 ms | 19.16 ms |
f8045b6 | 1226.25 ms | 1252.41 ms | 26.16 ms |
4a67681 | 1223.90 ms | 1252.63 ms | 28.73 ms |
a9db8a6 | 1199.83 ms | 1234.56 ms | 34.73 ms |
2ae7db9 | 1231.37 ms | 1239.98 ms | 8.61 ms |
88ac2c2 | 1223.04 ms | 1243.12 ms | 20.08 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bd284cf | 20.75 KiB | 405.06 KiB | 384.31 KiB |
f8045b6 | 20.75 KiB | 404.83 KiB | 384.08 KiB |
ae5ecd1 | 20.75 KiB | 383.31 KiB | 362.55 KiB |
459ae5e | 20.75 KiB | 383.50 KiB | 362.75 KiB |
ba46ce3 | 20.75 KiB | 405.10 KiB | 384.34 KiB |
f8045b6 | 20.75 KiB | 404.83 KiB | 384.08 KiB |
4a67681 | 20.75 KiB | 405.07 KiB | 384.31 KiB |
a9db8a6 | 20.75 KiB | 383.37 KiB | 362.62 KiB |
2ae7db9 | 20.75 KiB | 381.87 KiB | 361.12 KiB |
88ac2c2 | 20.75 KiB | 373.61 KiB | 352.86 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make CI happy again!!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2507 +/- ##
==========================================
+ Coverage 78.44% 78.46% +0.01%
==========================================
Files 241 241
Lines 22285 22293 +8
Branches 9838 9842 +4
==========================================
+ Hits 17482 17492 +10
+ Misses 4350 4348 -2
Partials 453 453
Continue to review full report at Codecov.
|
I made CI happy 😀, @brustolin. |
* 8.0.0: (31 commits) tests: Reenable testAddAndRemoveData (#2533) feat: support SENTRY_DSN environment var on macOS (#2534) Remove duplicate entry (#2532) fix: ARC issue for FileManager (#2525) feat: Add SwiftUI performance tracking (#2271) fix: Remove all permission checks (#2529) Remove the automatic `viewAppearing` span (#2511) Fix and reenable testANRDetected_UpdatesAppStateToTrue (#2526) fix: Don't add out of date context for crashes (#2523) ref: Rename isOOM to watchdog in Client (#2520) test: Fix disabled failing watchdog test (#2521) build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#2516) Rename the watchdog option and integration (#2513) feat: Enable CaptureFailedRequests by default (#2507) test: Fix asserts for SentryCrashTestInstallation (#2500) meta: User interaction tracing enabled per default (#2506) ref: Rename OOM to Watchdog Terminations (#2499) feat: enableUserInteractionTracing is GA (#2503) build(deps): bump nokogiri from 1.13.9 to 1.13.10 (#2505) perf: Don't attach headers for SentryNoOpSpan (#2498) ...
📜 Description
Enable CaptureFailedRequests by default.
💡 Motivation and Context
Feature is GA and creates value for customers. They can easily disable this if they don't want it.
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps
Will update the docs in a bigger 8.0.0 docs update branch once 8.0.0 is GA.