Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable CaptureFailedRequests by default #2507

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Dec 9, 2022

📜 Description

Enable CaptureFailedRequests by default.

💡 Motivation and Context

Feature is GA and creates value for customers. They can easily disable this if they don't want it.

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Will update the docs in a bigger 8.0.0 docs update branch once 8.0.0 is GA.

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9c8edbe

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.22 ms 1239.59 ms 22.37 ms
Size 20.75 KiB 405.10 KiB 384.34 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
bd284cf 1241.12 ms 1249.22 ms 8.10 ms
f8045b6 1206.76 ms 1233.41 ms 26.65 ms
ae5ecd1 1226.73 ms 1250.96 ms 24.23 ms
459ae5e 1223.84 ms 1250.14 ms 26.31 ms
ba46ce3 1231.70 ms 1250.86 ms 19.16 ms
f8045b6 1226.25 ms 1252.41 ms 26.16 ms
4a67681 1223.90 ms 1252.63 ms 28.73 ms
a9db8a6 1199.83 ms 1234.56 ms 34.73 ms
2ae7db9 1231.37 ms 1239.98 ms 8.61 ms
88ac2c2 1223.04 ms 1243.12 ms 20.08 ms

App size

Revision Plain With Sentry Diff
bd284cf 20.75 KiB 405.06 KiB 384.31 KiB
f8045b6 20.75 KiB 404.83 KiB 384.08 KiB
ae5ecd1 20.75 KiB 383.31 KiB 362.55 KiB
459ae5e 20.75 KiB 383.50 KiB 362.75 KiB
ba46ce3 20.75 KiB 405.10 KiB 384.34 KiB
f8045b6 20.75 KiB 404.83 KiB 384.08 KiB
4a67681 20.75 KiB 405.07 KiB 384.31 KiB
a9db8a6 20.75 KiB 383.37 KiB 362.62 KiB
2ae7db9 20.75 KiB 381.87 KiB 361.12 KiB
88ac2c2 20.75 KiB 373.61 KiB 352.86 KiB

Previous results on branch: feat/failed-requests

Startup times

Revision Plain With Sentry Diff
d3ccd85 1232.30 ms 1255.69 ms 23.39 ms

App size

Revision Plain With Sentry Diff
d3ccd85 20.75 KiB 405.07 KiB 384.31 KiB

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make CI happy again!!

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #2507 (9c8edbe) into 8.0.0 (bd284cf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            8.0.0    #2507      +/-   ##
==========================================
+ Coverage   78.44%   78.46%   +0.01%     
==========================================
  Files         241      241              
  Lines       22285    22293       +8     
  Branches     9838     9842       +4     
==========================================
+ Hits        17482    17492      +10     
+ Misses       4350     4348       -2     
  Partials      453      453              
Impacted Files Coverage Δ
Sources/Sentry/SentryOptions.m 87.20% <100.00%> (ø)
Sources/Sentry/SentryFileManager.m 94.95% <0.00%> (-0.64%) ⬇️
Sources/Sentry/SentrySessionCrashedHandler.m 100.00% <0.00%> (ø)
Sources/Sentry/SentryOutOfMemoryTracker.m
...rces/Sentry/SentryOutOfMemoryTrackingIntegration.m
Sources/Sentry/SentryOutOfMemoryLogic.m
Sources/Sentry/SentryOutOfMemoryScopeObserver.m
Sources/Sentry/SentryWatchdogTerminationsLogic.m 62.26% <0.00%> (ø)
Sources/Sentry/SentryWatchdogTerminationsTracker.m 100.00% <0.00%> (ø)
...s/Sentry/SentryWatchdogTerminationsScopeObserver.m 70.51% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd284cf...9c8edbe. Read the comment docs.

@philipphofmann
Copy link
Member Author

I made CI happy 😀, @brustolin.

@philipphofmann philipphofmann merged commit 6b8ec2a into 8.0.0 Dec 12, 2022
@philipphofmann philipphofmann deleted the feat/failed-requests branch December 12, 2022 14:15
kevinrenskers added a commit that referenced this pull request Dec 16, 2022
* 8.0.0: (31 commits)
  tests: Reenable testAddAndRemoveData (#2533)
  feat: support SENTRY_DSN environment var on macOS (#2534)
  Remove duplicate entry (#2532)
  fix: ARC issue for FileManager (#2525)
  feat: Add SwiftUI performance tracking (#2271)
  fix: Remove all permission checks (#2529)
  Remove the automatic `viewAppearing` span (#2511)
  Fix and reenable testANRDetected_UpdatesAppStateToTrue (#2526)
  fix: Don't add out of date context for crashes (#2523)
  ref: Rename isOOM to watchdog in Client (#2520)
  test: Fix disabled failing watchdog test (#2521)
  build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#2516)
  Rename the watchdog option and integration (#2513)
  feat: Enable CaptureFailedRequests by default (#2507)
  test: Fix asserts for SentryCrashTestInstallation (#2500)
  meta: User interaction tracing enabled per default (#2506)
  ref: Rename OOM to Watchdog Terminations (#2499)
  feat: enableUserInteractionTracing is GA (#2503)
  build(deps): bump nokogiri from 1.13.9 to 1.13.10 (#2505)
  perf: Don't attach headers for SentryNoOpSpan (#2498)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants