Set reject unauthorised to false for s3 #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
a3957273
requested changes
Nov 27, 2023
| node_modules.git | ||
| dist | ||
| config / local.cjs |
There was a problem hiding this comment.
I think you've accidentally formatted this file!
backend/src/clients/s3.ts
Outdated
| import config from '../utils/v2/config.js' | ||
|
|
||
| let client: S3Client | undefined |
There was a problem hiding this comment.
I'm not super keen on caching our agent like this. We try to use short-lived access tokens wherever possible. This will only work when we have a permanent access key / secret key setup.
a3957273
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.