Feature/bai 928 implement user monitoring in bailo v2 #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3957273
requested changes
Nov 27, 2023
| onCreateModel(req: Request, model: ModelDoc) { | ||
| this.checkEventType(AuditInfo.CreateModel, req) | ||
| const event = this.generateEvent(req, { id: model.id }) | ||
| log.info(event, req.audit.description) |
There was a problem hiding this comment.
I think we should still use req.log here and NOT provide user within the this.generateEvent() function. By using req.log we also store request related information (e.g. the UUID we use to link log messages together).
There was a problem hiding this comment.
After switching to using req.log.info() this is an example of what we get in the logs:
info - (file://connectors/v2/audit/stdout.ts:49): Model Searched (User={ dn: 'user' } EventDetail={
typeId: 'SearchModels',
resource: '{"url":"/api/v2/models/search?type=all&search=","results":["a-twfbex"]}'
})
I don't see any request related information?
a3957273
approved these changes
Dec 1, 2023
JR40159
deleted the
feature/BAI-928-implement-user-monitoring-in-bailo-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.