Feature/bai 951 model contributors and owners should be able to edit releases #867
Conversation
…s-should-be-able-to-edit-releases
| }, [isEdit, setUnsavedChanges]) | ||
|
|
||
| if (isModelError) { | ||
| return <MessageAlert message={isModelError.info.message} severity='error' /> |
There was a problem hiding this comment.
Did we decide on how we wanted to handle errors? Happy to leave this for another ticket if that's what we decided
There was a problem hiding this comment.
Yeah this is what we decided on. Any components that don't include the Wrapper can safely use a MessageAlert. Any of the page components with their own Wrapper will need to use the MultipleErrorWrapper
| <Box py={1}> | ||
| <EditableFormHeading | ||
| heading={ | ||
| <div> |
There was a problem hiding this comment.
Does this need to be a div or can we use a fragment?
There was a problem hiding this comment.
Internally the EditableFormHeading puts the heading inside of a Stack direction='row' so the div is needed so that these are rendered on top of each other instead of side-by-side. I've had to do the same for access requests too.
I thought about managing this within EditableFormHeading, but I decided to let us decide how the heading will look on a case-by-case basis instead.
| } | ||
|
|
||
| const releaseNotesLabel = ( | ||
| <Typography component='label' sx={{ fontWeight: 'bold' }} htmlFor={'new-model-description'}> |
There was a problem hiding this comment.
Can we replace the sx={} prop with fontWieght prop instead fontWeight: 'bold'
There was a problem hiding this comment.
I've changed this across the app for consistency
ARADDCC012
deleted the
feature/BAI-951-model-contributors-and-owners-should-be-able-to-edit-releases
branch
ARADDCC012
restored the
feature/BAI-951-model-contributors-and-owners-should-be-able-to-edit-releases
branch
ARADDCC012
deleted the
feature/BAI-951-model-contributors-and-owners-should-be-able-to-edit-releases
branch
No description provided.