Bug/Remove bubble when no reviews #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3957273
requested changes
Oct 24, 2023
| @@ -147,12 +147,12 @@ export default function SideNavigation({ | |||
| <ListItemIcon> | |||
| {!drawerOpen ? ( | |||
| <Tooltip title='Review' arrow placement='right'> | |||
| <Badge badgeContent={reviewCount} color='secondary'> | |||
| <Badge badgeContent={reviewCount} color='secondary' invisible={reviewCount == 0}> | |||
There was a problem hiding this comment.
Always use strict equality === when comparing values.
a3957273
requested changes
Oct 25, 2023
| @@ -91,7 +91,7 @@ export default function SideNavigation({ | |||
| }, []) | |||
|
|
|||
| async function fetchReviewCount() { | |||
| setReviewCount((await getReviewCount()).headers.get('x-count') as unknown as number) | |||
| setReviewCount((await getReviewCount()).headers.get('x-count') as string) | |||
There was a problem hiding this comment.
I think it would be cleaner to parse it as a number here. E.g:
setReviewCount(parseInt((await getReviewCount()).headers.get('x-count')))
Then reviewCount can remain a number, and you can compare it as a number
There was a problem hiding this comment.
Is it be preferable to raise an error on a null response or set the value to 0?
a3957273
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.