Add get docker images endpoint #740
Conversation
|
|
||
| export async function listImageTags(user: UserDoc, imageRef: RepoRef) { | ||
| const repo = `${imageRef.namespace}/${imageRef.model}` | ||
| const token = await getAccessToken({ id: user.dn, _id: user.dn }, [ |
There was a problem hiding this comment.
What is the difference between 'id' and '_id' ?
There was a problem hiding this comment.
We used to have the _id field represent the internal MongoDB ID and the 'id' field represent the public identifier of a user. This was confusing, so we now only use the 'dn' field to represent a user.
This id and _id is to make sure our registry continues working during the beta, as our registryAuth is still using the v1 authentication system.
| const repos = await listModelRepos(user, modelId) | ||
| const versions = await Promise.all( | ||
| repos.map(async (repo) => { | ||
| const [namespace, model] = repo.split('/') |
There was a problem hiding this comment.
Is the .split() used to keep a division between namespace and model?
There was a problem hiding this comment.
The repository is in the form x/y. We want to separate x, the namespace with y, the model. So we split it into two.
| images: Array<ImageInterface> | ||
| images: Array<{ | ||
| namespace: string | ||
| model: string |
There was a problem hiding this comment.
Is this the modelId? If so, is this necessary considering the model ID is included in the endpoint?
There was a problem hiding this comment.
No, this is the model artefact name in Docker.
| @@ -212,7 +213,7 @@ if (config.experimental.v2) { | |||
| server.post('/api/v2/model/:modelId/files/upload/multipart/finish', ...postFinishMultipartUpload) | |||
| server.delete('/api/v2/model/:modelId/files/:fileId', ...deleteFile) | |||
|
|
|||
| // *server.get('/api/v2/model/:modelId/images', ...getImages) | |||
| server.get('/api/v2/model/:modelId/images', ...getImages) | |||
There was a problem hiding this comment.
Is this obvious enough we are referring to Docker images?
There was a problem hiding this comment.
We could rename it getOCIImages, but that looks weird!
| import fetch from 'node-fetch' | ||
|
|
||
| import { UserDoc } from '../../models/v2/User.js' | ||
| import { getAccessToken } from '../../routes/v1/registryAuth.js' |
There was a problem hiding this comment.
I'm guessing a V2 version of this will be added at some point?
There was a problem hiding this comment.
Yes but we can only run one simultaneously, :(.
No description provided.