Add update model endpoint #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT38665
reviewed
Sep 20, 2023
| @@ -206,6 +206,20 @@ export async function updateModelCard( | |||
| return revision | |||
| } | |||
|
|
|||
| export type UpdateModelParams = Pick<ModelInterface, 'name' | 'description' | 'visibility'> | |||
| export async function updateModel(user: UserDoc, modelId: string, diff: Partial<UpdateModelParams>) { | |||
There was a problem hiding this comment.
Does the 'diff' stand for different/difference??
There was a problem hiding this comment.
I would assume so, a Partial is (like the name suggests) a type that contains some but not all of the properties of a given type.
I think we should probably rename this, but I am going to approve in case you're 100% set on this naming @a3957273
ARADDCC002
approved these changes
Sep 20, 2023
JR40159
requested changes
Sep 21, 2023
| @@ -206,6 +206,20 @@ export async function updateModelCard( | |||
| return revision | |||
| } | |||
|
|
|||
| export type UpdateModelParams = Pick<ModelInterface, 'name' | 'description' | 'visibility'> | |||
| export async function updateModel(user: UserDoc, modelId: string, diff: Partial<UpdateModelParams>) { | |||
| const model = await getModelById(user, modelId) | |||
There was a problem hiding this comment.
Why didn't you use findByIdAndUpdate()?
There was a problem hiding this comment.
We need to check the authorisation first.
JR40159
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.