Add release endpoints #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR40159
reviewed
Aug 31, 2023
|
|
||
| test('createRelease > bad authorisation', async () => { | ||
| authorisationMocks.userReleaseAction.mockResolvedValueOnce(false) | ||
| expect(() => createRelease({} as any, {} as any)).rejects.toThrowError(/^You do not have permission/) |
There was a problem hiding this comment.
For cases like this we could also assert that release.save() does not get called as well as the error getting thrown as those both seem like the two most important outcomes of someone not having the permission to do something like this?
JR40159
reviewed
Aug 31, 2023
JR40159
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds create, list, get and delete endpoints and their corresponding services.