Feature/bai 796 get api v2 schemas #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3957273
requested changes
Aug 3, 2023
| id: 'example-schema-2', | ||
| name: 'Example Schema 2', | ||
| description: '', | ||
| const schemas: Array<SchemaInterface> = await findSchemasByKind(query.kind) |
There was a problem hiding this comment.
Unnecessary typing. If TypeScript can't work it out for itself, you should add a return type to findSchemasByKind instead of putting it here.
| @@ -0,0 +1,45 @@ | |||
| import { SchemaKind } from '../../src/models/v2/Schema.js' | |||
|
|
|||
| export const testModelSchema = { | |||
There was a problem hiding this comment.
This file should probably be 'testSchemas' instead of 'testModels'.
There was a problem hiding this comment.
I think there's a misunderstanding of the meaning of 'models' in this context. I'm intending this file to be the V2 version of https://github.com/gchq/Bailo/blob/main/backend/src/utils/test/testModels.ts
backend/test/services/schema.spec.ts
Outdated
| } | ||
| }) | ||
| vi.mock('../../src/models/v2/Schema.js', () => ({ | ||
| SchemaKind: { |
There was a problem hiding this comment.
I think you should import this (via e.g. importActual), instead of mocking it. Alternatively, we could put it in a separate types folder.
a3957273
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.