Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bai 650 add warning message for max model upload size #637

Merged
merged 5 commits into from
Jul 21, 2023

Conversation

P20179
Copy link
Member

@P20179 P20179 commented Jul 21, 2023

Added functionality so that if the user tries to upload a combination of code, binary and docker files (or any one of these) that exceeds the maximum upload size we allow, they are presented with an error message which tells them the issue, what the upper limit is, and they cannot proceed to select upload.
The amount set is configurable and at the time of this PR is set within backend>config>default.cjs to 50 GB.
This PR also includes an improved Loading state which displays a loading spinner rather than a Wrapper, which was confusing to the user and not visually attractive.

P20179 added 5 commits July 17, 2023 16:26
Added basic functionality for the check of file sizes
Updated functionality to persist the error message if user browses to different pages, handle the errors, prevent user from submitting the model if exceeds max, add max to config so it is configurable
Fixed test failures
Added a more complete error message that tells user the max upload size
Slight edit to error message
@P20179 P20179 merged commit c715059 into main Jul 21, 2023
@P20179 P20179 deleted the BAI-650-add-warning-message-for-max-model-upload-size branch July 21, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants