Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock V2 Endpoints #635

Merged
merged 9 commits into from
Jul 25, 2023
Merged

Mock V2 Endpoints #635

merged 9 commits into from
Jul 25, 2023

Conversation

JR40159
Copy link
Member

@JR40159 JR40159 commented Jul 20, 2023

No description provided.

@a3957273 a3957273 changed the title Feature/initial v2 mock endpoints Mock V2 Endpoints Jul 24, 2023
JR40159
JR40159 commented Jul 24, 2023
View reviewed changes
backend/src/routes.ts Outdated
server.delete('/api/v2/model/:modelId/releases/:semver', ...deleteRelease)

server.get('/api/v2/model/:modelId/files', ...getModelFiles)
server.post('/api/v2/model/:modelId/files/upload/simple', ...postSimpleUpload)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this endpoint?

JR40159
JR40159 commented Jul 24, 2023
View reviewed changes
backend/src/routes/v2/release/deleteRelease.ts Outdated

interface DeleteReleaseResponse {
data: {
success: boolean
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to a message on success

JR40159
JR40159 commented Jul 24, 2023
View reviewed changes
backend/src/routes/v2/schema/getSchemas.ts Outdated

inactive: false,
hidden: false,
use: 'deployment',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to kind

JR40159
JR40159 commented Jul 24, 2023
View reviewed changes
backend/src/routes/v2/team/getMyTeams.ts Outdated

export const getMyTeamsSchema = z.object({})

interface PatchTeamResponse {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy & paste error

@JR40159 JR40159 merged commit 91b8fed into main Jul 25, 2023
@JR40159 JR40159 deleted the feature/initial-v2-mock-endpoints branch July 25, 2023 11:39
@JR40159 JR40159 restored the feature/initial-v2-mock-endpoints branch August 3, 2023 11:41
@JR40159 JR40159 deleted the feature/initial-v2-mock-endpoints branch August 3, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a3957273 a3957273 a3957273 approved these changes

@ARADDCC002 ARADDCC002 ARADDCC002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JR40159 @a3957273 @ARADDCC002