Bugfix/bai 367 user receives no feedback #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARADDCC002
reviewed
Jul 12, 2023
frontend/pages/review.tsx
Outdated
| setOpen(false) | ||
| await postEndpoint(`/api/v1/approval/${approval?._id}/respond`, { choice }).then((res) => { | ||
| if (res.status !== 200) { | ||
| console.log(res) |
ARADDCC002
reviewed
Jul 12, 2023
frontend/pages/review.tsx
Outdated
| if (res.status !== 200) { | ||
| console.log(res) | ||
| res.json().then((errorResponse) => { | ||
| console.log(errorResponse) |
ARADDCC002
approved these changes
Jul 13, 2023
a3957273
reviewed
Jul 13, 2023
frontend/pages/review.tsx
Outdated
| mutateNumApprovals() | ||
| setOpen(false) | ||
| await postEndpoint(`/api/v1/approval/${approval?._id}/respond`, { choice }).then((res) => { | ||
| if (res.status !== 200) { |
There was a problem hiding this comment.
It's safer to check >= 400. All 2xx and 3xx responses are successes.
a3957273
reviewed
Jul 13, 2023
frontend/pages/review.tsx
Outdated
| setOpen(false) | ||
| await postEndpoint(`/api/v1/approval/${approval?._id}/respond`, { choice }).then((res) => { | ||
| if (res.status !== 200) { | ||
| res.json().then((errorResponse) => { |
There was a problem hiding this comment.
Make this an async function, then you can write
const errorResponse = await res.json()
setShowAlert(true)
setErrorMessage(errorResponse.message)
Which is generally clearer.
a3957273
requested changes
Jul 17, 2023
frontend/pages/review.tsx
Outdated
| setOpen(false) | ||
| await postEndpoint(`/api/v1/approval/${approval?._id}/respond`, { choice }).then(async (res) => { | ||
| if (res.status >= 400) { | ||
| const errorResponse = await res.json() |
There was a problem hiding this comment.
This catches every SERVER error. E.g. 'Approval cannot be found'. It does not handle NETWORK errors. E.g. 'Could not reach server'.
There is a getErrorMessage exported from utils/fetcher which should be used instead. If can handle more errors.
Instead of:
const errorResponse = await res.json()
It's:
const errorResponse = await getErrorMessage(res)
added 2 commits
July 18, 2023 08:39
a3957273
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of the backend being broken, whilst the user tries to approve/reject a model, an error message has been implemented to give the user feedback that it is broken.