Bai 551 approve reject directly from model #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added complete functionality so that if the user has permissions to approve a model, they can do so directly from the model page, rather than having to navigate to Review. The button has been updated to reflect this and improve user experience.
One outstanding issue that has been noted is that the badges that display the 'count' of approvals (how many are remaining to be reviewed) are not synchronised on the approve button on the model page and on the Review option, as we are not using a state sharing solution like Redux.
Scenario example: If there are 2 approvals to be made and you are the approver for both, and you are on the model page, you will see a badge displaying '2' on the button on that page and on the Review tab on the left side of the screen. If you select to approve from the model page, the count there will drop to '1' but on the side will still show as '2' until you refresh the page or navigate to any other page. It won't automatically do it in snychronised real time.
We were uncertain of a solution for this, or at least within the scope of this ticket, but it would be great to hear any suggestions