Feature/bai 1461 manual rerequest filescanning #1633
Conversation
…, additional properties such as lastRanAt and scannerVersion
|
The "Last ran at..." text does not appear when viruses are found, neither does the scanner version tag, and I think it would be helpful to see the time for when a scan was last run to check whether re-running a scan has completed or not. |
| if (!file) { | ||
| throw BadReq('Cannot find requested file', { modelId: modelId, fileId: fileId }) | ||
| } | ||
| const auth = await authorisation.model(user, model, ModelAction.Update) |
There was a problem hiding this comment.
Could we add a FileAction.Update?
There was a problem hiding this comment.
Don't forget to add tests for this new route.
| @@ -152,3 +156,28 @@ export async function getTotalFileSize(fileIds: string[]) { | |||
| }) | |||
| return totalSize.at(0).totalSize | |||
| } | |||
|
|
|||
| export async function rerunFileScan(user: UserInterface, modelId, fileId: string) { | |||
There was a problem hiding this comment.
To prevent the scanners being overloaded, we could first check if a scan is already underway?
| @@ -152,3 +156,28 @@ export async function getTotalFileSize(fileIds: string[]) { | |||
| }) | |||
| return totalSize.at(0).totalSize | |||
| } | |||
|
|
|||
| export async function rerunFileScan(user: UserInterface, modelId, fileId: string) { | |||
Does migration 009 not cover this use case? |
|
Test what happens when a scanner is killed off part way through a scan - we want to be able to catch this and update the scan result to "could not complete" rather than indefinitely reporting "virus scan in progress". |
|
|
||
| let av: NodeClam | ||
| export const clamAvToolName = 'Clam AV' | ||
| const maxInitRetries = 5 |
There was a problem hiding this comment.
I'd like the max retry count maxInitRetries = 5 and delay between pings 10000 to be configurable like retryDelayInMinutes e.g. connectors.fileScanners.maxInitRetries and connectors.fileScanners.initRetryDelay.
| @@ -113,8 +113,8 @@ describe('clients > modelScan', () => { | |||
| ) | |||
| }) | |||
|
|
|||
| test('scanStream > rejected', async () => { | |||
| fetchMock.default.mockRejectedValueOnce('Unable to communicate with the inferencing service.') | |||
| test('scanFile > rejected', async () => { | |||
There was a problem hiding this comment.
Revert scanFile to scanStream
…est name of modelscan
No description provided.