Dockerise our ModelScan application #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR40159
requested changes
Nov 18, 2024
lib/modelscan_api/Dockerfile.dev
Outdated
| @@ -0,0 +1,19 @@ | |||
| FROM python:3.12-slim | |||
There was a problem hiding this comment.
Did you consider using a bullseye image rather than a slim one as we do here? https://github.com/gchq/Bailo/blob/main/backend/Dockerfile#L2
There was a problem hiding this comment.
I had not. It looks like 3.12-slim resolves to 3.12-slim-bookend which is one major Debian release ahead of bullseye. I'm happy to downgrade to 3.12-slim-bullseye as there are no meaningful functionality changes.
Is there a reason we don't use the slim docker image for the docs build?
JR40159
requested changes
Nov 18, 2024
JR40159
requested changes
Nov 18, 2024
JR40159
approved these changes
Nov 19, 2024
PE39806
deleted the
feature/BAI-1502-dockerise-our-model-scan-application
branch
PE39806
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a Dockerfile for the REST Model Scan application.
The Dockerfile should expose the relevant ports.
The Image should be added to the dev docker compose build.