added a popover for av results on files #1507
Conversation
backend/config/default.cjs
Outdated
| @@ -205,6 +209,10 @@ module.exports = { | |||
| audit: { | |||
| kind: 'silly', | |||
| }, | |||
|
|
|||
| avScanning: { | |||
There was a problem hiding this comment.
We also have this config in this file:
avScanning: {
enabled: false,
clamdscan: {
host: '127.0.0.1',
port: 3310,
},
},
Should they all be enabled/disabled or is it expected that they're not aligned?
| </Grid> | ||
| <Grid item xs={1} textAlign='right'> | ||
| <Typography variant='caption'>{prettyBytes(file.size)}</Typography> | ||
| <> |
There was a problem hiding this comment.
This fragment can be removed
| @@ -135,6 +135,10 @@ export interface Config { | |||
| text: string | |||
| startTimestamp: string | |||
| } | |||
|
|
|||
| avScanning: { | |||
| enabled: boolean | |||
There was a problem hiding this comment.
You need to remove the existing avScanning.enabled configuration, as they're now duplicated.
There was a problem hiding this comment.
The configuration to enable av scanning should be in the Docker Compose configuration file because you need to use Docker Compose to have the AV scanner running
| @@ -191,6 +190,10 @@ module.exports = { | |||
| text: '', | |||
| startTimestamp: '', | |||
| }, | |||
|
|
|||
| avScanning: { | |||
There was a problem hiding this comment.
By default, we don't want avScanning enabled because you need to have an ClamAV instance running somewhere
backend/src/services/file.ts
Outdated
There was a problem hiding this comment.
You'll need to update the mocked config
No description provided.