improved response quoting by adding original commenter name and date #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ARADDCC002
commented
Aug 1, 2024
ARADDCC002
commented
GB27247
suggested changes
Aug 6, 2024
Comment on lines
75
to
81
| if (isUserInformationLoading) { | ||
| return <Loading /> | ||
| } | ||
|
|
||
| if (isUserInformationError) { | ||
| return <MessageAlert message={isUserInformationError.info.message} severity='error' /> | ||
| } |
There was a problem hiding this comment.
Is it important for the error catch to be before the catch for loading?
| const handleReactionsError = useCallback((message: string) => { | ||
| setErrorMessage(message) | ||
| }, []) | ||
|
|
||
| const handleReplyOnClick = (value: string | undefined) => { | ||
| setAnchorEl(null) | ||
| if (value) { | ||
| onReplyButtonClick(value.replace(/^/gm, '>')) | ||
| const username = userInformation ? userInformation.name : response.entity.split(':')[1] | ||
| const originalComment = value.replace(/^/gm, '>') |
There was a problem hiding this comment.
Do we want the reply to a reply quoted as well?
If not it might also be good to consider making the quoted comment read only, rather than using editable block quotes.
There was a problem hiding this comment.
There currently isn't really a way to handle that as the response is just a string that's formatted by the Rich Text component.
I think we'd need to make a lot of changes in order to make it read-only and I don't know how much benefit we'd get for how long that might take, but I'm open to change my opinion on that.
GB27247
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.