Feature/refactor review responses #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GB27247
suggested changes
Jul 8, 2024
backend/src/services/response.ts
Outdated
| break | ||
| } | ||
| default: | ||
| throw GenericError(500, 'Review Kind not recognised', reviewIdQuery) |
There was a problem hiding this comment.
Is this suppose to be a Generic Error or an Internal Error?
backend/test/services/review.spec.ts
Outdated
| @@ -171,6 +160,7 @@ describe('services > review', () => { | |||
| expect(smtpMock.requestReviewForAccessRequest).toBeCalled() | |||
| }) | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
What's the reason these tests are commented out?
There was a problem hiding this comment.
Good spot, thank you! I commented them out and then moved them to the new response.spec.ts for some reason. I'll delete the comment block now they've been moved.
Comment on lines
+77
to
+78
|
|
||
| // Store the response |
There was a problem hiding this comment.
Is it worth checking if a review has already been approved? And perhaps throwing an error?
GB27247
approved these changes
Jul 8, 2024
ARADDCC012
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: