BAI-1141 Experiment Ordering #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GB27247
suggested changes
Jul 4, 2024
lib/python/src/bailo/helper/model.py
Outdated
Comment on lines
499
to
514
| if len(self.raw): | ||
| for run in self.raw: | ||
| if run["run"] == run_id: | ||
| sel_run = run | ||
| break | ||
| else: | ||
| raise NameError(f"Run {run_id} does not exist.") | ||
| if (select_by is None) and (run_id is None): | ||
| raise BailoException( | ||
| "Either select_by (e.g. 'MIN|MAX:accuracy) or run_id is required to publish an experiment run." | ||
| ) | ||
| if (select_by is not None) and (run_id is None): | ||
| sel_run = self.__select_run(select_by=select_by) | ||
| if run_id is not None: | ||
| for run in self.raw: | ||
| if run["run"] == run_id: | ||
| sel_run = run | ||
| break | ||
| else: | ||
| raise NameError(f"Run {run_id} does not exist.") | ||
| else: | ||
| raise BailoException(f"This experiment has no runs to publish.") |
There was a problem hiding this comment.
Could we make this flat rather than nested.
| def publish( | ||
| self, | ||
| mc_loc: str, | ||
| semver: str = "0.1.0", |
There was a problem hiding this comment.
Can we avoid giving a default. It's not used anywhere else in the application.
lib/python/src/bailo/helper/model.py
Outdated
| runs = self.raw | ||
| for run in runs: | ||
| metrics = run["metrics"] | ||
| for m in metrics: |
There was a problem hiding this comment.
Could we use for metric in metrics: for clarity.
lib/python/tests/test_model.py
Outdated
Comment on lines
154
to
162
| @pytest.mark.integration | ||
| def test_publish_experiment_standard_ordered(standard_experiment): | ||
| standard_experiment.publish(mc_loc="performance.performanceMetrics", select_by="MAX:accuracy") | ||
|
|
||
| model_card = standard_experiment.model.model_card | ||
| model_card = NestedDict(model_card) | ||
| metrics_array = model_card[("performance", "performanceMetrics")][0]["datasetMetrics"] | ||
|
|
||
| expected_accuracy = 0.5 |
lib/python/src/bailo/helper/model.py
Outdated
| :param semver: Semantic version of release to create (if artifacts present), defaults to 0.1.0 or next | ||
| :param notes: Notes for release, defaults to "" | ||
| :param run_id: Local experiment run ID to be selected, defaults to None | ||
| :param select_by: String describing experiment to be selected (e.g. "MIN|MAX:accuracy"), defaults to None |
There was a problem hiding this comment.
Format with this in accordance with MLFlow
There was a problem hiding this comment.
Done, now accuracy MIN|MAX
GB27247
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.