Bai 1247 create a basic read only model #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns when an mirror model is used. Also added unit tests and resolved exsisting unit tests that were affected by refactored code.
JR40159
requested changes
May 22, 2024
JR40159
requested changes
May 22, 2024
JR40159
requested changes
May 31, 2024
backend/src/services/model.ts
Outdated
| @@ -32,6 +32,9 @@ export async function createModel(user: UserInterface, modelParams: CreateModelP | |||
| }) | |||
|
|
|||
| const auth = await authorisation.model(user, model, ModelAction.Create) | |||
| if (model.settings.mirror.sourceModelId && model.settings.mirror.destinationModelId) { | |||
There was a problem hiding this comment.
I think you should move this check to the start of the function and check the contents of modelParams.settings
JR40159
requested changes
May 31, 2024
JR40159
requested changes
May 31, 2024
JR40159
requested changes
May 31, 2024
a3957273
requested changes
Jun 3, 2024
backend/src/services/model.ts
Outdated
| export async function updateModel( | ||
| user: UserInterface, | ||
| modelId: string, | ||
| modelDiff: Partial<UpdateModelParams>, |
There was a problem hiding this comment.
Why not include settings in the model? What makes settings special?
There was a problem hiding this comment.
Ah. Presumably because we only use Object.assign() below, which isn't recursive. I would prefer a recursive merging here, as opposed to treating 'settings' as a special case. I think something like:
.mergeWith({}, model, modelDiff, (a, b) =>
_.isArray(b) ? b : undefined
);
Might work.
JR40159
approved these changes
Jun 4, 2024
a3957273
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.