Enable local replica set + enable basic authentication #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCHQDeveloper36
changed the title
|
I've put this back into draft as I noticed upon restarting the Mongo container it seems to struggle to become primary. Should be fixable but I won't be able to look at it till Friday. Happy to take feedback on the PR as a whole though and I can incorporate anything into it on the next go-around. |
GCHQDeveloper36
force-pushed
the
dev/use-rs-locally
branch
from
d9b7af0 to
ecb9ff2
Compare
GCHQDeveloper36
changed the title
|
Must have been something weird locally as it seems fine today. Tests now pass, missed it was using the prod docker compose in CI/CD. If desired, I can tweak the prod compose to be a three-member replica set. |
a3957273
approved these changes
Jun 28, 2024
GB27247
added a commit
that referenced
this pull request
Jul 1, 2024
Revert "Merge pull request #1236 from GCHQDeveloper36/dev/use-rs-loca…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on transactions, I noticed the local instance wasn't quite in replica set mode, possibly after my switch to the Bitnami image.
Authentication seems to be required, I wasn't able to force it to be disabled during dev but happy to try again or take suggestions on that. If it remains enabled, I've followed the pattern for other services of
serviceadminfor user/pass here but happy to use something else.It may require dropping the mongo Docker volume if you struggle to bring it up when testing these changes, though the Bitnami image 'should' adapt automatically.