Disable create and edit buttons on failure #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARADDCC002
reviewed
Apr 15, 2024
| @@ -31,6 +31,7 @@ export default function ModelAccess({ model }: ModelAccessProps) { | |||
| const [userListQuery, setUserListQuery] = useState('') | |||
| const [loading, setLoading] = useState(false) | |||
| const [errorMessage, setErrorMessage] = useState('') | |||
| const [roleError, onRoleError] = useState(false) | |||
There was a problem hiding this comment.
As this is a boolean I would rename this to isRoleError and setIsRoleError.
ARADDCC002
reviewed
Apr 15, 2024
| @@ -143,7 +145,13 @@ export default function ModelAccess({ model }: ModelAccessProps) { | |||
| </TableHead> | |||
| <TableBody>{accessListEntities}</TableBody> | |||
| </Table> | |||
| <LoadingButton variant='contained' aria-label='Save access list' onClick={updateAccessList} loading={loading}> | |||
| <LoadingButton | |||
There was a problem hiding this comment.
If this is disabled due to the roleError value being set to true I would add some error text below the button explaining the error.
It might be more work, but you could replace the boolean and have it as a string, and when you set roleError inside UserDisplay set it to error message created by isUserInformationError.
ARADDCC012
requested changes
Apr 29, 2024
ARADDCC012
reviewed
Apr 29, 2024
ARADDCC012
requested changes
Apr 30, 2024
frontend/pages/model/[modelId]/access-request/[accessRequestId]/review.tsx
Outdated
Show resolved
Hide resolved
ARADDCC012
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.