Improve logging #1160
Merged
Improve logging #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT38665
reviewed
Mar 15, 2024
TT38665
approved these changes
Mar 18, 2024
a3957273
requested changes
Mar 19, 2024
backend/src/services/log.ts
Outdated
| function ProductionStream() { | ||
| return { | ||
| write: (log) => { | ||
| const namespace = getNamespace('my session') |
There was a problem hiding this comment.
Maybe make this 'bailo' or equivalent?
backend/src/services/log.ts
Outdated
| @@ -147,7 +157,8 @@ if (process.env.NODE_ENV !== 'production') { | |||
| // In production environments output plain JSON logs | |||
| streams.push({ | |||
| level: config.log.level, | |||
| stream: process.stdout, | |||
| type: 'raw', | |||
| stream: ProductionStream(), | |||
There was a problem hiding this comment.
I'm inclined to say that we should add elasticsearch to our dev environments too!
There was a problem hiding this comment.
Could you expand on this, are there changes you're suggesting for this PR?
| req.log = log.child({ | ||
| id: req.reqId, | ||
| user: req.user?.id, |
There was a problem hiding this comment.
are we losing user from the request logs?
There was a problem hiding this comment.
These lines did nothing because the middleware that added the user to the request obtain had been run yet.
a3957273
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.