Feature/bai 849 use open telemetry to send instrumentation info #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3957273
requested changes
Mar 8, 2024
backend/Dockerfile
Outdated
| CMD ["node", "--import=./src/instrumentation.js", "src/index.js"] |
There was a problem hiding this comment.
I'm not a fan of imports like this, they add hidden complexity to the running of an application and are not standard. Can we replace this with a bare import (e.g. import './instrument.js') within src/index.ts?
|
|
||
| instrumentation: { | ||
| enabled: false, | ||
| serviceName: 'backend', |
There was a problem hiding this comment.
This should probably include authenticationToken. The config should include every possible field, even if it defaults to empty.
|
Add the ability to turn on OT debug model via config |
ARADDCC013
approved these changes
Mar 11, 2024
a3957273
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.