Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditional rendering has been done to make sure that the latest versi… #1021

Merged
merged 2 commits into from
Feb 6, 2024
Merged

conditional rendering has been done to make sure that the latest versi… #1021

merged 2 commits into from
Feb 6, 2024

Conversation

TT38665
Copy link
Member

@TT38665 TT38665 commented Jan 19, 2024

…on does not show when viewing a release

a3957273
a3957273 requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@a3957273 a3957273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also probably don't want to display this when editing a model, because the release semver can't be created there either!

@TT38665
Copy link
Member Author

TT38665 commented Jan 19, 2024

We also probably don't want to display this when editing a model, because the release semver can't be created there either!

It's covered in the conditional rendering. The latest version does not show when you click on a release or when editing a model.

@ARADDCC012
Copy link
Member

We also probably don't want to display this when editing a model, because the release semver can't be created there either!

Can confirm that when the form is in editable mode, the form is being used for View and Edit. If it's not in editable mode the form is being used for Create only. So by conditionally showing the latest version when not in editable mode, it'll only show on the create release page.

@ARADDCC012 ARADDCC012 requested a review from a3957273 January 22, 2024 14:55
@a3957273 a3957273 merged commit be09eca into main Feb 6, 2024
15 checks passed
@a3957273 a3957273 deleted the bugfix/BAI-1113-remove-latest-version branch February 6, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a3957273 a3957273 a3957273 approved these changes

@ARADDCC012 ARADDCC012 ARADDCC012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TT38665 @ARADDCC012 @a3957273