Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/migrate release and review #1004

Merged
merged 8 commits into from
Jan 15, 2024
Merged

Conversation

JR40159
Copy link
Member

@JR40159 JR40159 commented Jan 12, 2024

No description provided.

if (approval.status === ApprovalStates.Accepted) {
responses.push({
user: toEntity('user', approver.id),
decision: Decision.Approve,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to both of these responses to note that the response has been migrated from V1

@JR40159 JR40159 marked this pull request as ready for review January 15, 2024 10:41
@JR40159 JR40159 merged commit 6685f72 into main Jan 15, 2024
@JR40159 JR40159 deleted the feature/migrate-release-and-review branch January 15, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants