Skip to content

Commit

Permalink
Merge pull request #1322 from gchq/feature/upgrade-registry-deployment
Browse files Browse the repository at this point in the history
Upgrade registry deployment
  • Loading branch information
JR40159 authored Jun 12, 2024
2 parents 6dba760 + bc18202 commit ed06638
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ spec:
labels:
name: backend
spec:
{{- if .Values.backend.serviceAccount }}
serviceAccountName: {{ .Values.backend.serviceAccount }}
{{- end }}
{{- with .Values.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/helm/bailo/templates/certs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ metadata:
{{- include "bailo.labels" . | nindent 4 }}
type: Opaque
data:
{{ (.Files.Glob "certs/**.pem").AsSecrets | indent 2 }}
{{ (.Files.Glob "{certs/**.pem,certs/jwks.json}").AsSecrets | indent 2 }}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ data:
cache:
blobdescriptor: inmemory
s3:
{{- if .Values.minio.enabled }}
{{- if .Values.minio.enabled }}
regionendpoint: {{ ternary "https" "http" (eq .Values.minio.useSSL true)}}://{{ include "bailo.minio.host" . }}:{{ .Values.minio.service.ports.api }}
{{- end }}
bucket: {{ .Values.minio.registryBucket }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ spec:
labels:
name: registry
spec:
{{- if .Values.registry.serviceAccount }}
serviceAccountName: {{ .Values.registry.serviceAccount }}
{{- end }}
{{- with .Values.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
Expand All @@ -40,16 +43,6 @@ spec:
value: {{ .Values.registry.certDir }}/{{ .Values.registry.certFile }}
- name: REGISTRY_HTTP_TLS_KEY
value: {{ .Values.registry.certDir }}/{{ .Values.registry.keyFile }}
- name: REGISTRY_STORAGE_S3_ACCESSKEY
valueFrom:
secretKeyRef:
name: {{ include "bailo.fullname" . }}-minio
key: root-user
- name: REGISTRY_STORAGE_S3_SECRETKEY
valueFrom:
secretKeyRef:
name: {{ include "bailo.fullname" . }}-minio
key: root-password
- name: REGISTRY_AUTH
value: "token"
- name: REGISTRY_AUTH_TOKEN_REALM
Expand All @@ -61,6 +54,8 @@ spec:
value: "RegistryIssuer"
- name: REGISTRY_AUTH_TOKEN_ROOTCERTBUNDLE
value: {{ .Values.registry.certDir }}/{{ .Values.registry.certFile }}
- name: REGISTRY_AUTH_TOKEN_JWKS
value: {{ .Values.registry.certDir }}/{{ .Values.registry.jwksFile }}
- name: REGISTRY_HTTP_SECRET
valueFrom:
secretKeyRef:
Expand All @@ -87,3 +82,5 @@ spec:
path: {{ .Values.registry.certFile }}
- key: {{ .Values.nginxcert.key }}
path: {{ .Values.registry.keyFile }}
- key: {{ .Values.registry.jwksFile }}
path: {{ .Values.registry.jwksFile }}
15 changes: 6 additions & 9 deletions infrastructure/helm/bailo/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -178,15 +178,17 @@ minio:
# Registry Dependencies
registry:
repository: registry
tag: 2
tag: 3.0.0-alpha.1
enabled: true
protocol: "https"
#host: "bailo-registry" # service name
port: 5000 # default 5000
insecure: "true"
certDir: "/certs"
certFile: cert.pem #use san.cnf to create certs
jwksFile: jwks.json
keyFile: key.pem
serviceAccount: ''

# Nginx Dependencies
nginxAuth:
Expand All @@ -210,11 +212,6 @@ openshift:

# Instance Settings
config:
s2i:
name: "seldonio - 1.10.0"
image: seldonio/seldon-core-s2i-python37:1.10.0
supportEmail: "[email protected]"

ui:
banner:
enabled: false
Expand All @@ -231,9 +228,6 @@ config:
pass: "mailpass"
from: "[email protected]"

build:
environment: img # 'img' for k8s | eks and 'openshfit' for openshift

app:
protocol: "https"
port: 443
Expand Down Expand Up @@ -263,3 +257,6 @@ inference:
# Url for the inferencing cluster
host: 'https://example.com'
gpus:

backend:
serviceAccount: ''

0 comments on commit ed06638

Please sign in to comment.