Merge pull request #1474 from gchq/bugfix/update-model-settings

Reverted change to model merging during update
gchq · Aug 28, 2024 · df339f9 · df339f9
2 parents c90e93a + 2d2d384
commit df339f9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/backend/src/services/model.ts b/backend/src/services/model.ts
@@ -1,4 +1,5 @@
 import { Validator } from 'jsonschema'
+import _ from 'lodash'
 
 import authentication from '../connectors/authentication/index.js'
 import { ModelAction, ModelActionKeys } from '../connectors/authorisation/actions.js'
@@ -320,7 +321,7 @@ export async function updateModel(user: UserInterface, modelId: string, modelDif
     throw Forbidden(auth.info, { userDn: user.dn })
   }
 
-  Object.assign(model, modelDiff)
+  _.mergeWith(model, modelDiff, (a, b) => (_.isArray(b) ? b : undefined))
   await model.save()
 
   return model