Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong macro name in FreeBSD config for RISCV #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kartatz
Copy link

@Kartatz Kartatz commented Feb 15, 2025

The author of 48abb54 misspelled the macro name in the FreeBSD config file for RISCV. This unfortunately causes the compilation of GCC toolchains targeting riscv64-unknown-freebsd14.* to fail with the following error:

In file included from ./tm.h:44,
                 from ../../gcc/gcc.cc:35:
../../gcc/config/riscv/freebsd.h:45:5: error: expected ‘,’ or ‘;’ before ‘FBSD_LINK_PG_NOTES’
   45 |   " FBSD_LINK_PG_NOTES "                                                \
      |     ^~~~~~~~~~~~~~~~~~
../../gcc/gcc.cc:1211:32: note: in expansion of macro ‘LINK_SPEC’
 1211 | static const char *link_spec = LINK_SPEC;
      |                                ^~~~~~~~~

The author of 48abb54 misspelled the macro name in the FreeBSD config file for RISCV. This unfortunately causes the compilation of GCC toolchains targeting riscv64-unknown-freebsd14.* to fail with the following error:

In file included from ./tm.h:44,
                 from ../../gcc/gcc.cc:35:
../../gcc/config/riscv/freebsd.h:45:5: error: expected ‘,’ or ‘;’ before ‘FBSD_LINK_PG_NOTES’
   45 |   " FBSD_LINK_PG_NOTES "                                                \
      |     ^~~~~~~~~~~~~~~~~~
../../gcc/gcc.cc:1211:32: note: in expansion of macro ‘LINK_SPEC’
 1211 | static const char *link_spec = LINK_SPEC;
      |                                ^~~~~~~~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant