Fix CurTransMat::combine_matrix for arm-unknown-linux-gnueabi #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method uses f32::mul_add which is completely broken on this target. See Rust issue rust-lang/rust#46950. The workaround is less accurate than f32::mul_add, but works correctly.
|
Well that's a new one, lol. PDFs not working due to a compiler bug. Thanks for debugging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the library!
I tried to use it on a Raspberry Pi Zero and got incorrect PDF files. After some research, it turned out that
CurTransMat::combine_matrixdoes not work on the targetarm-unknown-linux-gnueabidue to a bug in Rust compiler.This MR implements a workaround.
The only problem is that Rust currently doesn't support cfg(target) and therefore this workaround will also apply to all ARMs, regardless. But this shouldn't be a problem. If accuracy and performance are very important, I will make this fix an optional feature.